search

seethroughdev / obsidian-recipe-grabber

MIT License
59 stars 8 forks source link

Copy recipe image locally #10

Closed illusionistpm closed 5 months ago

illusionistpm commented 1 year ago

It'd be nice if the image for the recipe was copied locally, so that we aren't reliant on the original website staying up forever.

Flxp49 commented 10 months ago

Hi there. This feature is in and will go out in the next release!

seethroughdev commented 10 months ago

Yep, this is definitely something people have wanted, and thanks to @Flxp49 for getting it in there so well.

Question though, I'm not super sure saving images locally should be the default behavior. My expectation is most users will be fine using the weblink to these images, and since many users do not go through the settings initially, this behavior might be unexpected.

Do either of you, or anyone else have a strong opinion here?

Flxp49 commented 10 months ago

Question though, I'm not super sure saving images locally should be the default behavior. My expectation is most users will be fine using the weblink to these images, and since many users do not go through the settings initially, this behavior might be unexpected.

I do agree with you here. I'll push a commit to the PR with the default being set to disabled (and additions to README).

illusionistpm commented 10 months ago

I think people are fine with weblinks, until the website goes down, and then they're sad and have no recourse. I think they're storing their recipes in Obsidian in part for permanence. That said, it is just the image we're talking about so if they lose it, it's much less of an issue than the recipe proper.