search

seethroughdev / obsidian-recipe-grabber

MIT License
59 stars 8 forks source link

Update main.ts to decode html chars #20

Closed derekthecool closed 10 months ago

derekthecool commented 10 months ago

I'm getting words like this in my text doesn't

Thanks for the wonderful plugin!

seethroughdev commented 10 months ago

Thanks for taking the time to do this @derekthecool . Though, i'm not sure that change is going to do what you want, unless you are specifically printing out the json into your document.

However, there were some improvements to the escaping text in the last version. Can you download the latest, and go into settings and template: Reset to Default if you haven't made any custom changes there?

Hopefully that will fix up your issue on its own. If not, please create an issue and we can try and reproduce.

derekthecool commented 10 months ago

Right, I did see your new update and have found it works well. Thanks for such a wonderful project. Yes, let's close this pull request. I have a few comment the below, I would love your feedback.

Though it does require toggling the prevent escaping HTML option on. And the warning scares my with saying to only use this if you know what you're doing.

I don't understand all the risks or hazards of doing so. Can you explain more?

seethroughdev commented 10 months ago

So glad you've found it helpful. And I'm second guessing the warning there as well. I don't know if there's any actual risk here either. Since markdown is likely already covering this.

I'll create a ticket to try and get more insight on the subject, and also likely soften the warning as well. Thanks again!