search

seewhyjay / pe

0 stars 0 forks source link

Both UG and DG do not mention what details cannot be the same in order for a `Person`, `Event`, `Venue` to be considered duplicate #12

Open seewhyjay opened 10 months ago

seewhyjay commented 10 months ago

It would be good to mention which fields are checked to see if the added person or the other objects is a duplicate person/other objects.

UG section

image.png

DG section

image.png

nus-pe-script commented 10 months ago

Team's Response

We acknowledged that it is good to explicitly show which fields are checked to see if the added person or the other objects is a duplicate person/other objects. However, we mentioned that The adding of a person is case-sensitive. e.g John will not be the same as john. Hence, We believe that this line has sufficiently explained that it is the name field that affects whether a person/object is considered a duplicate.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** A lot has to be inferred from that one line in order to come to the conclusion that only name is considered when considering if the person is a duplicate.