implement get all mentors public endpoint

janithlahirukariyawasam commented 8 months ago

Purpose

The purpose of this PR is to fix #14

Goals

The goal of this PR is to implement get all mentors public endpoint

Approach

Screenshots

Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Related PRs

## Test environment ## Learning

janithlahirukariyawasam commented 8 months ago

@anjula-sack I think it is good to write unit test cases for the service layer instead of the routes. and I think the reason for the test failure is we wrote unit test cases without mocking the repositories

anjula-sack commented 8 months ago

@anjula-sack I think it is good to write unit test cases for the service layer instead of the routes. and I think the reason for the test failure is we wrote unit test cases without mocking the repositories

Can you create an issue for that? @janithlahirukariyawasam

sef-global / scholarx-backend