Update mentor profile UI

sef-global / scholarx-frontend

This is the frontend of the ScholarX

MIT License

5 stars 58 forks source link

Closed AnsarMahir closed 2 months ago

AnsarMahir commented 2 months ago

The purpose of this PR is to Update mentor profile UI #171

[ ] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[ ] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

## Test environment ## Learning

closes #171

anjula-sack commented 2 months ago

@AnsarMahir The tests are failing can you check?

AnsarMahir commented 2 months ago

@anjula-sack The issue seems like package-lock and package-json was not in sync. did the necessary changes

anjula-sack commented 2 months ago

can you update this to version 18 in e2e.yml? @AnsarMahir

AnsarMahir commented 2 months ago

changed the node version to 18 from 16. @anjula-sack

anjula-sack commented 2 months ago

Still failing @AnsarMahir. Can you remove the package-lock.json changes?

anjula-sack commented 2 months ago

@Madhawa97 Can you help @AnsarMahir with this actions failure?

AnsarMahir commented 2 months ago

@anjula-sack updated the package.json and package-lock file by replacing them with the files in the repo.

AnsarMahir commented 2 months ago

@anjula-sack Do not merge

AnsarMahir commented 2 months ago

@anjula-sack did the changes

AnsarMahir commented 2 months ago

@anjula-sack Hopefully done.

AnsarMahir commented 2 months ago

There's a lint failure

@anjula-sack fixed