sef-global / sef-handbook

https://handbook.sefglobal.org
MIT License
0 stars 13 forks source link

Add new "Team Responsibilities" page #22

Closed YoshithaRathnayake closed 1 year ago

YoshithaRathnayake commented 1 year ago

Purpose:

The purpose of this PR is to fix #21

Related to:

Engineering team page

Please provide a brief explanation for this change:

This PR adds a new section called "Team Responsibilities" to the engineering team page

Preview Link:

https://pr-22-sef-handbook.surge.sh/

Please indicate the types of revisions being suggested for the Handbook (please check all that apply):

Author Checklist

YoshithaRathnayake commented 1 year ago

@anjula-sack @miniskynet Can you review this changes?

miniskynet commented 1 year ago

Hi @YoshithaRathnayake. We want the new content in a new subsection page like this. The page should fall under the engineering team page: image

YoshithaRathnayake commented 1 year ago

Hi @YoshithaRathnayake. We want the new content in a new subsection page like this. The page should fall under the engineering team page: image

Ok, can you tell me that file, which I should edit. @miniskynet

miniskynet commented 1 year ago

@YoshithaRathnayake You see that the dropdown of Handbook section has 3 subsections? Just like that create a subsection called Team Responsibilities for the Engineering Team section. Go through the category.json files, you'll get a better understanding on how sectioning works. You need to create a new md file for this.

YoshithaRathnayake commented 1 year ago

@YoshithaRathnayake You see that the dropdown of Handbook section has 3 subsections? Just like that create a subsection called Team Responsibilities for the Engineering Team section. Go through the category.json files, you'll get a better understanding on how sectioning works. You need to create a new md file for this.

Ok I'll try

miniskynet commented 1 year ago

@YoshithaRathnayake You see that the dropdown of Handbook section has 3 subsections? Just like that create a subsection called Team Responsibilities for the Engineering Team section. Go through the category.json files, you'll get a better understanding on how sectioning works. You need to create a new md file for this.

Ok I'll try

Please refer to this PR if you want a better understanding

YoshithaRathnayake commented 1 year ago

@YoshithaRathnayake You see that the dropdown of Handbook section has 3 subsections? Just like that create a subsection called Team Responsibilities for the Engineering Team section. Go through the category.json files, you'll get a better understanding on how sectioning works. You need to create a new md file for this.

Ok I'll try

Please refer to this PR if you want a better understanding

Thanks @miniskynet

YoshithaRathnayake commented 1 year ago

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

miniskynet commented 1 year ago

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

YoshithaRathnayake commented 1 year ago

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

miniskynet commented 1 year ago

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

A new page in a dropdown like this:

image

YoshithaRathnayake commented 1 year ago

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

A new page in a dropdown like this:

image

So we can't create a dropdown in a current working page right? It should be blank (no page, only a link) @miniskynet

miniskynet commented 1 year ago

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

@miniskynet so I should create a dropdown like subsection with the name Engineering Team, then I should insert this team responsibilities page to that subsection, then where should I put the engineering team page, should I insert it to the engineering team subsection? Because can't add a page to the subsection

Keep Engineering Team page as it is. The Team Responsibilities should be a new page which falls under the Engineering Team page.

Not in a dropdown right? Just a new page? @miniskynet

A new page in a dropdown like this: image

So we can't create a dropdown in a current working page right? It should be blank (no page, only a link) @miniskynet

I think you are a bit confused. Let's have a call. Please reach out to me on slack :)

YoshithaRathnayake commented 1 year ago

Yes, I am. Ok I'll

YoshithaRathnayake commented 1 year ago

image

In my way the one and only solution is this @miniskynet

YoshithaRathnayake commented 1 year ago

I'll close this PR and open a new one