sef-global / sef-site

Official Website for Sustainable Education Foundation
https://sefglobal.org
MIT License
51 stars 137 forks source link

Implement COHORT filters with Dynamic Rendering #1507

Closed janithlahirukariyawasam closed 1 year ago

janithlahirukariyawasam commented 1 year ago

Purpose

The purpose of this PR is to fix #1504

Goals

The goal of this PR is to implement cohort filters with Dynamic rendering of checkboxes. We don't need to update the source code with the new google sheet updates

Approach

Screenshots

image

Preview Link

https://pr-1507-sef-site.surge.sh/ https://pr-1507-sef-site.surge.sh/scholarx/archive/

Checklist

Related PRs

## Learning
janithlahirukariyawasam commented 1 year ago

@anjula-sack @YoshithaRathnayake Can you review this?

janithlahirukariyawasam commented 1 year ago

@anjula-sack if we begin our for loop with the first year and iterate until the last year, I think it is easy know? because this year's value was used in different places inside the for loop. image If not we have maintained a variable call year outside of the for loop.

anjula-sack commented 1 year ago

@anjula-sack if we begin our for loop with the first year and iterate until the last year, I think it is easy know? because this year's value was used in different places inside the for loop. image If not we have maintained a variable call year outside of the for loop.

What if the year array is not sorted?

janithlahirukariyawasam commented 1 year ago

@Gravewalker666 Can you review this.

janithlahirukariyawasam commented 1 year ago

I am sorry @Gravewalker666, I have learnt how to use javascript filters with this PR thank you very much.

anjula-sack commented 1 year ago

@Gravewalker666 can you review this again?