search

sef-global / sef-site

Official Website for Sustainable Education Foundation
https://sefglobal.org
MIT License
50 stars 137 forks source link

Implement University filters with dynamic rendering #1520

Closed janithlahirukariyawasam closed 1 year ago

janithlahirukariyawasam commented 1 year ago

Purpose

The purpose of this PR is to fix #1466

Goals

The goal is to render the university dropdown with filter functionality.

Preview Link

https://pr-1520-sef-site.surge.sh/ https://pr-1520-sef-site.surge.sh/scholarx/archive/

Checklist

Related PRs

## Learning
janithlahirukariyawasam commented 1 year ago
  1. There will be no mentee results from year 2022 to 2026 because of the empty fields. (We only added the mentors details)
  2. When we use Year by filters, current selection of university filters will be cleared. Is it ok or need to be improved?
  3. Opinion about university filter dropdown design? is it ok? @anjula-sack can you review this?
anjula-sack commented 1 year ago
  1. There will be no mentee results from year 2022 to 2026 because of the empty fields. (We only added the mentors details)
  2. When we use Year by filters, current selection of university filters will be cleared. Is it ok or need to be improved?
  3. Opinion about university filter dropdown design? is it ok? @anjula-sack can you review this?

The university filter needs to be a checkbox. For ex: If I want to select mentees from UoP and UoK, the dropdown will not do it. @janithlahirukariyawasam

janithlahirukariyawasam commented 1 year ago

@anjula-sack Can you check now? There are two University of Moratuwa checkboxes due to different way of naming in sheet side

janithlahirukariyawasam commented 1 year ago

@anjula-sack Can you check now? There are two University of Moratuwa checkboxes due to different way of naming in sheet side

Fixed! from the sheet side. There was an extra '.' after the university name ( eg: University of Moratuwa.)

anjula-sack commented 1 year ago

Looks great! @janithlahirukariyawasam. What do you think @Madhawa97? We can improve the design a bit later.

janithlahirukariyawasam commented 1 year ago

@anjula-sack

  1. Increased uni filter width and height
  2. left align the text
  3. Converted to lowercase
Madhawa97 commented 1 year ago

Looks great! @janithlahirukariyawasam. What do you think @Madhawa97? We can improve the design a bit later.

I'm sorry @anjula-sack. Somehow I've missed this notification. The filter looks great with the recent changes. Great job @janithlahirukariyawasam

Will it be possible to sort the list of universities? maybe alphabetically. @janithlahirukariyawasam

janithlahirukariyawasam commented 1 year ago

Looks great! @janithlahirukariyawasam. What do you think @Madhawa97? We can improve the design a bit later.

I'm sorry @anjula-sack. Somehow I've missed this notification. The filter looks great with the recent changes. Great job @janithlahirukariyawasam

Will it be possible to sort the list of universities? maybe alphabetically. @janithlahirukariyawasam

Thank you Madhawa for the suggestion. Can you check now? And also can give me some suggestion about #1525 this profile model pr? is it ok?