search

sef-global / sef-site

Official Website for Sustainable Education Foundation
https://sefglobal.org
MIT License
50 stars 137 forks source link

Reduce the image size of Student Ambassador page #1610

Closed nimeshkavindu closed 7 months ago

nimeshkavindu commented 7 months ago

Purpose

Reduce the image size of Student Ambassador page #1479

Goals

Reducing the image size of Student Ambassador page

Approach

Reduced the main image size of Student Ambassador page.

Screenshots

OnPaste 20240114-191307

Preview Link

https://pr-1610-sef-site.surge.sh/student-ambassador.html

Checklist

Related PRs

## Learning
nimeshkavindu commented 7 months ago

Hi, @nimeshkavindu so some changes to be changed.

  1. In the Pull Request template you have to put the issue number at The purpose of this PR is to fix #IssueNumber
  2. At the goals section you have to put the goal of the PR. (Eg: Reducing the image size of Student Ambassador page)
  3. In the Approach section you have to put how you did this like the steps you have done.
  4. At the preview link section https://pr-{pr_number}-sef-site.surge.sh/ it is like this no so you have to remove this thing {pr_number} and replace the pull request number there and at the last add the folder/file name like https://pr-XXXX-sef-site.surge.sh/student-ambassador.html..
  5. At the screenshot section you have to put a screenshot taken in the preview of the change you have done (Eg: The screenshot of the reduced image with whole page)

Done.

YoshithaRathnayake commented 7 months ago

Hi, @nimeshkavindu so some changes to be changed.

  1. In the Pull Request template you have to put the issue number at The purpose of this PR is to fix #IssueNumber
  2. At the goals section you have to put the goal of the PR. (Eg: Reducing the image size of Student Ambassador page)
  3. In the Approach section you have to put how you did this like the steps you have done.
  4. At the preview link section https://pr-{pr_number}-sef-site.surge.sh/ it is like this no so you have to remove this thing {pr_number} and replace the pull request number there and at the last add the folder/file name like https://pr-XXXX-sef-site.surge.sh/student-ambassador.html..
  5. At the screenshot section you have to put a screenshot taken in the preview of the change you have done (Eg: The screenshot of the reduced image with whole page)

Done.

Great! @nimeshkavindu Do this https://github.com/sef-global/sef-site/pull/1610#discussion_r1451749540