sef-global / sef-site

Official Website for Sustainable Education Foundation
https://sefglobal.org
MIT License
50 stars 137 forks source link

Fix the Learn More button redirecting problem on the Join Us page #1617

Closed RamithaHeshan33 closed 4 months ago

RamithaHeshan33 commented 4 months ago

Purpose

Fixing the issue of "Learn More" button on the Join Us page opening in the same page #1612

Goals

After clicking the "Learn More" button handbook will open from new tab

Approach

Modified the "join-us.html" file. I used the attribute called "target='_blank' "

Screenshots

Screenshot 2024-04-08 202512

Preview Link

https://pr-1617-sef-site.surge.sh/

Checklist

anjula-sack commented 4 months ago

@RamithaHeshan33 Can you drop a message on the relevant issue so i can assign you?

YoshithaRathnayake commented 4 months ago

@YoshithaRathnayake Can you check and review my PR.

No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33

Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it!

RamithaHeshan33 commented 4 months ago

@RamithaHeshan33 Can you drop a message on the relevant issue so i can assign you?

Sure @anjula-sack. I created this pull request for issue number #1612 (Fix the "Learn More" button link on the Join Us page opening in the same page) I will add a screenshot of the issue below to make the problem more clear.

Screenshot 2024-04-16 125350

Before Fixing the Issue

https://github.com/sef-global/sef-site/assets/142712365/5a417809-765e-4e6b-a7d1-78dd7aa262b8

After Fixing the Issue

https://github.com/sef-global/sef-site/assets/142712365/6a77857d-165f-4a72-a2dc-f9b91937f859

RamithaHeshan33 commented 4 months ago

@YoshithaRathnayake Can you check and review my PR.

No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33

Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it!

Thanks for the reviewing PR @YoshithaRathnayake. Yes, it was my first time. Sorry for putting a pull request before assigning and Thank you for your guidance.

YoshithaRathnayake commented 4 months ago

@YoshithaRathnayake Can you check and review my PR.

No problem in the PR btw, just put a comment on the issue to be assigned to this issue as @anjula-sack said @RamithaHeshan33 Development Best Practises If you read this you will find that first of all you should be assigned for a issue, bcs this is your first time its ok so just go to the issue and drop a comment that you are working on it!

Thanks for the reviewing PR @YoshithaRathnayake. Yes, it was my first time. Sorry for putting a pull request before assigning and Thank you for your guidance.

No problem @RamithaHeshan33

YoshithaRathnayake commented 4 months ago

So can you drop a comment in the issue #1612 otherwise I won't be able to assign you for the issue @RamithaHeshan33