search

sefeng211 / faviconSwitcher

Replace ugly favicons!
Mozilla Public License 2.0
15 stars 2 forks source link

Didn't work at first, but after a few restarts #3

Open BoneheadFraggle opened 4 years ago

BoneheadFraggle commented 4 years ago

Edit: At first it didn't work at all but after a couple of add/remove and a Firefox restart the Favicon Switcher icon finally showed up and then it was quite easy to configure and it works fine.

You see the original favicon flash at load, but then it is changed to the chosen one.

However, when I bookmark the page, the original icon is shown. Maybe a feature request?

sefeng211 commented 4 years ago

Sorry for the late reply, somehow I missed the notification.

I think the issue for it didn't work after a couple of add/remove could be related to the how the code interacts with indexedDB, I don't like the current implementation and have some plans to improve it.

Thanks for pointing out the bookmarks, I totally missed it while I was working on it. I'll look into it.

sefeng211 commented 4 years ago

Looks like at the moment, favicon of bookmarks are not accessible, https://bugzilla.mozilla.org/show_bug.cgi?id=1315616