search

sefidgaran / signalr_client

A Flutter SignalR Client for ASP.NET Core
https://pub.dev/packages/signalr_netcore
MIT License
71 stars 112 forks source link

Removing BrowserClient #7

Closed mikeesouth closed 3 years ago

mikeesouth commented 3 years ago

Removing BrowserClient because it breaks pub.dev compatibility checks for native applications (even though it works just fine with iOS / Android apps). The benefit of BrowserClient is that it supports http only cookies (response cookies) that are often used in SPA authentication scenarios. But the regular http client supports other types of authentication so this shouldn't be that big of a deal for most users.

sefidgaran commented 3 years ago

Hi @mikeesouth, Thanks for the PR. About the https://pub.dev/packages/signalr_core package I gave it a try but it was not working in my case (I did not investigate to find out why) on that time so I used this package till now it is working perfectly.

mikeesouth commented 3 years ago

Great, looks good on pub.dev now. I guess you can reply and close https://github.com/sefidgaran/signalr_client/issues/5 too. I'm still having the same issue with both this package and signalr_core, I've filed the issue here: https://github.com/jamiewest/signalr_core/issues/58

I haven't received an answer but I think the error may come from the sse_client library so I'm going to investigate that soon. Both this package and signalr_core uses that library. SSE is only used by clients that does not support websockets and in my case that is iOS 12.