search

sefinek / Sefinek-Blocklist-Collection

🌍 A comprehensive repository of blocklists for various DNS servers, featuring over 100 links and more than 6 million domains. Additionally, you can use our personalized Blocklist Generator to tailor content filtering according to your specific needs, giving you full control over what gets blocked on your network.
https://blocklist.sefinek.net
Other
554 stars 26 forks source link

False positive #37

Closed whoot closed 4 months ago

whoot commented 4 months ago

The blocklist blocklists/generated/0.0.0.0/gambling/TrustPositif/gambling-indonesia.fork.txt contains the entry postimg.cc which is neither an indonesian site. nor a gambling site, but an image upload site.

sefinek commented 4 months ago

Added to the whitelist. Thanks!

whoot commented 4 months ago

Thanks, but why add it to the whitelist instead of removing the entry from the list? I mean its clearly a false positive and shouldn't be in the list in the first place.

Another false positive is i.ibb.co in the same list. It's also an image upload site (belongs to imgbb.com).

sefinek commented 4 months ago

No worries, what is added to the whitelist will be removed from the designated files after a few minutes. And that's exactly what happened, check this commit: https://github.com/sefinek24/Sefinek-Blocklist-Collection/commit/59c2dea15d6aed82d279dc2bf6e02b984c4df64c

Around 1 AM Polish time, the domain you provided will also be removed on blocklist.sefinek.net. Check out https://blocklist.sefinek.net for more useful information.

Regarding issues with false positives, it happens that sites like i.ibb.co are mistakenly identified as dangerous by some antivirus programs, which may be due to the fact that they are sometimes used to host malicious files by third parties. However, these sites themselves are not malicious, see: Malwarebytes Forums for example.

I have also added i.ibb.co to the whitelist in commit https://github.com/sefinek24/Sefinek-Blocklist-Collection/commit/a4762176163b72476e215dd7e20e26b66835ba2a. This triggered a GitHub Actions task. After a few minutes, a new commit was added (https://github.com/sefinek24/Sefinek-Blocklist-Collection/commit/ff59ab8b616987323a161644fdbf5a05e9caa3e6) that removed i.ibb.co from the gambling/TrustPositif/gambling-indonesia.fork.txt list. With the next list update, the excluded domain will of course be omitted.

'gambling/TrustPositif/gambling-indonesia.fork.txt' => Set(2) { 'postimg.cc', 'i.ibb.co' }
whoot commented 4 months ago

Oh I see. Thanks for the explanation.