Inconsistent hold on certain maps

segabl / pd2-useful-bots

A lightweight bot overhaul

GNU General Public License v3.0

8 stars 6 forks source link

Inconsistent hold on certain maps #20

Closed ghost closed 1 year ago

ghost commented 1 year ago

So recently, the bots wouldn't always stay in one place as they were told on the tiny stairs in the middle of "The Diamond - Holdout" and at the doors of "Boat Load - Holdout". I can't find a correlation why, but it hasn't happened to me on any other levels yet. I have got footage of it on Boat Load below. I doubt it's due to the doors, as the spot on The Diamond doesn't have a moving object.

Video: https://youtu.be/VfCrosPnyis

segabl commented 1 year ago

looks like something is making them switch cover points, not sure this is holdout specific. you see them walking back to their intended spots though so the objective itself is not broken

ghost commented 1 year ago

I've only encountered it in those two Holdout maps for now. If I do on a normal map, I'll be sure to post that footage here.

ghost commented 1 year ago

Happens semi-consistently (3/4) on "White House" in front of the PEOC computer. This time they always broke hold only once before staying at their assigned location.

Video: https://youtu.be/qSD_-3iB7y4

segabl commented 1 year ago

This seems to be related to them reloading, iirc the attack logic tries to make them move to cover while reloading. you should see it much more form bots with low mag sizes and much less from bots with large ones. If you can confirm this is related I can look into disabling that check.

ghost commented 1 year ago

I did a bit of testing, and I think I've managed to narrow down some things about it.

It does require enemies to be present, but doesn't trigger if the bot only needs to reload.
It happens very consistently on that spot when there are a lot of enemies around. But can still be triggered by just a few.
The bot won't always start moving when reloading. Sometimes they haven't even fired a shot as they start moving.
It seems to only trigger if the bot has been recently told to hold, not if the situation is encountered later on.
Only certain spots cause this behaviour, and it doesn't seem to happen when the bot is entirely out in the open. Possibly it only triggers when the spot is already near valid cover.

If you want to review the testing footage yourself, I'll link it here. It's cut down heavily to the parts that made me believe what I wrote above, but if you want, I can also give you the entirety of it.

Video: https://youtu.be/H4pP9V4beus

segabl commented 1 year ago

Yeah I'm expecting it to happen less out in the open, as there are usually no defined cover spots close enough. This is definitely caused by cover searching behavior though so I'll look into that when I have time. As they will return to their original positions relatively quickly, it's not a high priority atm.