search

segabor / Hunspell

Ruby wrapper for the famous spell checker library hunspell.
GNU Lesser General Public License v3.0
35 stars 11 forks source link

Add analyze method #8

Closed reneklacan closed 7 years ago

segabor commented 7 years ago

Hi,

Thanks for the contribution. PR looks great.

Just a question before merging it, response [" st:paprika po:noun ts:NOM"] yielded by the test code starts with a whitespace. What do you think it should be there. Also, the string itself consists of things separated by whitespace. Is it possible that those tokens should be the members of the resulting array? Unfortunately I'm not familiar with Hunspell_analyze and wanted to make sure the new function returns exactly the expected result. Thanks,

Gábor

segabor commented 7 years ago

Questions responded by the internet. I'm going to merge the PR and prepare a new release. Thanks again,

Gábor

reneklacan commented 7 years ago

@segabor Yes, it was weird to me too. I double checked the output of python module and original C library to make sure it's not a bug in my implementation.

Thank you for merging it!