segdeha / phpfr

Automatically exported from code.google.com/p/phpfr
0 stars 0 forks source link

External Links in PHP Manual #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use PHPfr to lookup the "header" function in the PHP manual.
2. Click the first link: "HTTP/1.1 specification".

What is the expected output? What do you see instead?
This is an external link in the PHP manual.  The expected output is the content 
of the hypertext 
reference.  Instead, you will see an error message.

In the specific case of the header function, the hypertext reference should be 
the following 
location: http://www.faqs.org/rfcs/rfc2616

Currently, PHPfr performs a global search and replace on all links in the pages 
it displays.  Links 
to external websites will not work.

Options for enhancement (brainstorm):

1. Refinement

Refining the global search and replace so that external links retain their 
integrity.
External links should probably open in the user's default browser, forcing an 
exit from the 
dashboard, so the user ought to be warned.  Perhaps a style could be applied to 
external links to 
visually denote an external reference.  The user could also be prompted with a 
dialog and given 
the options to either cancel their click, open the link in the default browser, 
or open the link in 
the background.

2. Disengagement

Disable external links by stripping their anchor tag.

Original issue reported on code.google.com by kellypat...@gmail.com on 10 Apr 2007 at 5:22

Attachments:

GoogleCodeExporter commented 9 years ago
References:

scripts/PHPfr.js:51-57
scripts/PHPfr.js:605

Original comment by kellypat...@gmail.com on 10 Apr 2007 at 5:50

GoogleCodeExporter commented 9 years ago
This now works as of 1.0b.

Original comment by segdeha on 27 Mar 2008 at 4:34