search

segeeslice / Meetify-UI

This is the React-driven UI for the Meetify program
GNU General Public License v3.0
2 stars 1 forks source link

Eliminate findDOMNode deprecation warnings #20

Open segeeslice opened 3 years ago

segeeslice commented 3 years ago

Warnings appear when new UI components are rendered without a proper reference. This doesn't seem to affect performance, but it would be useful to look into.

Example warning:

0.chunk.js:239193 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node

segeeslice commented 3 years ago

It appears that eliminating this bug is entirely dependent on updating our material-ui package, per this Stack Overflow question. Otherwise, we would need to actually go into the material-ui files and change how they use the findDOMNode() method.

According to that Stack Overflow, it is updated in v5 which is currently in alpha (status at this link).

So we can either:

The second appears to be the most viable solution for now, so as this isn't a breaking bug, so we'll just have to keep watch on it.