segeeslice / Meetify-UI

This is the React-driven UI for the Meetify program
GNU General Public License v3.0
2 stars 1 forks source link

#23 - Add default text to profile description when user doesn't have one set #27

Closed mtwn105 closed 3 years ago

mtwn105 commented 3 years ago

I added "Your Profile Description" as a default profile description.

segeeslice commented 3 years ago

Hey @mtwn105 ! Thanks for your interest in our project. Unfortunately this change will have to be denied.

The change you've done is within the store, which is a good guess! But this data will actually be overwritten when a user logs in and their data is loaded, which is currently the case in the dev branch.

What the issue asks for is to instead change the UI component in Account.jsx to expect an empty string as a description, as would be the case if a user logs in and has never set a personal description. This would then display some placeholder text.

I hope this makes sense! In any case, this project is still very under development, primarily in the dev branch. I'd ask you to make the change there, but running and testing there requires some internal access for running our server, which I won't be able to give you. i.e. I'm afraid we won't take contributions at this time. But thank you again for your interest!