search

seges / acris

AcrIS is a modern framework serving as a base for applications, web sites and portals. It provides various tools and libraries to ease daily development. Build on top of Google web toolkit and provides sophisticated solution for security, beans binding, JSON protocol and usefull project skelets integrated with maven, hibernate, spring and gilead. You will get a prepared solution in box ready to use in your own project.
4 stars 1 forks source link

No Tabs in pom.xml #91

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
According to http://maven.apache.org/developers/conventions/code.html : 
Indentation: Never use tabs!

acris pom.xml files are using tabs everywhere.

$ grep -P '\t' `find acris-read-only/ -iname pom.xml`|wc -l
6544

I'm reporting it because I was having a readability issue.

Original issue reported on code.google.com by spun...@gmail.com on 12 May 2013 at 2:29

GoogleCodeExporter commented 9 years ago 
Also 

$ grep -r -P '\t' acris-read-only/ |wc
 115121  432915 15156351

We need to retab all the files to spaces.

Original comment by spun...@gmail.com on 12 May 2013 at 2:32

GoogleCodeExporter commented 9 years ago 
Also, all the style guides on this page: 
https://code.google.com/p/google-styleguide/ (except javascript) explicitly 
state to use only spaces for indentation.

Original comment by spun...@gmail.com on 12 May 2013 at 2:38

GoogleCodeExporter commented 9 years ago 
Those mentioned style guides are applicable for those particular projects, so 
it does mean if you want to contribute to those projects you have to follow it. 
We have different opinion on using tabs in source code, therefore we use it in 
pom files and source code. We do not intend to change it and we are also not 
willing to participate in any flame wars in this regard.

Original comment by ladislav...@gmail.com on 12 May 2013 at 11:18