segler-alex / RadioDroid

radio browser app that uses www.radio-browser.info on android
GNU General Public License v3.0
755 stars 156 forks source link

Improvements to delete individual bookmarked stations #296

Open davidhedlund opened 6 years ago

davidhedlund commented 6 years ago

RadioDroid 0.5.1

In Bookmarks:

Delete button

Undo message

You can swipe the station left to remove it, after that "undo" button will appear below for short time. The "Undo" message disappears after 3 seconds, I suggest that you delay the time.

werman commented 6 years ago

You can swipe the station left to remove it, after that "undo" button will appear below for short time.

davidhedlund commented 6 years ago

@werman Thanks, I added a suggested improvement for that too.

nekohayo commented 8 months ago

From what I've seen with version 0.86 (which is maybe the result of me inheriting default settings from previous versions of the year or two before), the usability problems with the existing "star" icon button in the Favorites listview boil down to these aspects:

It would be much clearer if you moved it to the expanding toolbar (the one that occurs when you tap the v on the right) by default, with a predictable and reliable UX. For everything else¹, there's the fullscreened station detail view where you can also toggle the favorite status.

Here are my precise interaction design recommendations:

  1. Maybe move the > (play in external play) button to the left (instead of right-aligned)
  2. Move the "remove favorite" action to be a "trash" button (or colored star) into the Favorites view's list item's expandable toolbar (the one that shows up when tapping the v revealer button on the right), instead.
    Maybe as the right-most item in that toolbar if you have done the change proposed in step 1.
  3. Remove the "click-favorites" star from the cover thumbnail overlay in favorites view (we're already in favorites view, we know they are favorites!), and remove the "click-favorites" setting's effect over the favorites view, it doesn't really make sense (particularly while inside the Favorites listview).
  4. Consider making the swipe-to-unfavorite/delete gesture an opt-in setting by default, as it is too dangerous and easy to trigger (especially when manipulating the app on a bike or in a moving vehicle). This might help indirectly solve issue #1191 in the process.

When unfavoriting (unstarring) an item from within the Favorites view, it could show an undoable action for 5-8 seconds (or until another deletion happens) as an overlay (like when swiping), in case the user has hit that star button accidentally.


Why remove the setting entirely in step 3? Because the less settings there are for users to shoot themselves in the foot, the easier your app is to test and maintain. See this video for a very short mathematical demonstration of the problem.

Wikinaut commented 8 months ago

I am very happy with the current design which was developed to allow very easy and quick bookmarking, compared to other Internet Radio apps and programs it was designed for RadioDroid to avoid click orgies.

nekohayo commented 8 months ago

You can already quickly and easily bookmark stations from the browsing/searching search results. My proposal to clean up the favorites view takes nothing away from that. Removing stations is a much less frequent action, but it needs to be clear, reliable and easy.

I am not against "click thumbnail to make it a favorite" in the browsing/search results if that's what it could be limited to. Just not in the favorites view.