segler-alex / radiobrowser-api-rust

radio-browser API implementation in rust
GNU Affero General Public License v3.0
227 stars 97 forks source link

change default limit to 1000 #182

Closed ljufa closed 10 months ago

ljufa commented 1 year ago

Default value of 999999 seems unreasonable high. It would kill server and db pretty quickly if many users start clicking links provided in the api documentation, or multiple clients start calling api without pagination params.

vdbhb59 commented 11 months ago

Even 1000 seems very high, presuming the limit is set per-timeout perspective and that time difference is not too high. 250 seems better based on the normal db standards.