search

segler-alex / radiobrowser

website frontend with angular for radio-browser api
GNU Affero General Public License v3.0
116 stars 30 forks source link

Check for duplicate URL when adding a new station #244

Open diracsbracket opened 3 years ago

diracsbracket commented 3 years ago

Hi. It seems that URL's are not checked for duplicates when adding a new station? I accidently added a station and afterwards realized it is already there. I noticed other duplicates exist as well.

This should be easy enough to check before a new station is accepted?

I don't know who the admin is, but please, could he/she remove the duplicate I created?

The URL in question is

http://aac.cbs.co.kr/cbs939/_definst_/cbs939.stream/playlist.m3u8

and is listed as channel in Korea (The Republic of)

CBS
cbs music

Although I added the CBS entry, I would suggest to remove the cbs music entry, as it has neither the uppercase formatting of the name, nor the standard logo.

Also, I wanted to add the coordinates of the radio, but I no longer can, since radios cannot be edited. Please add:

lat: 37.52837514190113
lon: 126.87499001328894

The problem of duplicate URLs really should be addressed, as they make the whole experience really messy.

Another pair of duplicates, also under Korea (The Republic of) are:

gugak
GugakFM

Altough they have a different playlist part in the URL, they are the same.

http://mgugaklive.nowcdn.co.kr/gugakradio/gugakradio.stream/playlist.m3u8
https://mgugaklive.nowcdn.co.kr/gugakradio/gugakradio.stream/chunklist_w253831608.m3u8

This also highlights the other problem of name format. There should be guidelines about names. E.g.

Cheers!

segler-alex commented 3 years ago

on the main add screen on the right side, a list of stations with similiar names already in the database is displayed. also the warning to check the list before adding stations.

i am currently working on a solution to remove duplicate stations that are already in the database.

diracsbracket commented 3 years ago

on the main add screen on the right side, a list of stations with similiar names already in the database is displayed. also the warning to check the list before adding stations.

Some users (like me) are just too blind sometimes to see such warnings... In any case, to avoid duplicates in the future, the script simply should disallow creating stations with duplicate stream end-points and display the reason why the addition failed to the user. That would make it clear.

I also noticed that some stations are provided with some lousy icon link, although better alternatives (from the same original radio site) exist. An example is:

https://www.nrj.be/build/images/favicon.ico

As provided by station with name NRJ in Belgium, which is a low-resolution icon utterly useless in most applications. This site also has the following, scalable vector graphics version:

https://www.nrj.be/build/images/logo-nrj-red.svg

Although I understand the reasons for disallowing station edits, even by the original creator, there should be a button such as "Suggest Station Edit" or so next the station entry... The question then is of course, who will process those suggestions...

In any case, thank you so much for your much appreciated efforts!