search

segler-alex / rhythmbox-radio-browser

Internet radio browser plugin for rhythmbox
http://www.programmierecke.net/programmed/
12 stars 4 forks source link

Does not show in menu with rhythmbox 0.13.3 #21

Open giallu opened 13 years ago

giallu commented 13 years ago

I am on Fedora 14 and until few days ago I was happily using the radio browser with rhythmbox 0.13.1.

After the last update (0.13.3) the "Radio Browser" menu item does not show anymore. I'd love to help more in diagnosing the issue but I've no idea how to :)

mcanard commented 13 years ago

I have just now tried to install this plugin with rhythmbox 13.3, also running on Fedora 14. The "Radio Browser" menu item does not appear.

If the author provides some details on where to look to provide input, I'd be happy to help. I can say there are no messages in the system log (/var/log/messages). I am running SELinux, but there are no indications in the audit log of any denials. A quick run with rhythmbox -d did not show anything, of interest.

It would be nice to be able to use the plugin!

giallu commented 13 years ago

Ok. the plugins API obviously changed because running in debug mode I get:

Traceback (most recent call last): File "/usr/lib64/rhythmbox/plugins/radio-browser/radio-browser.py", line 120, in activate group = rb.rb_source_group_get_by_name ("library") AttributeError: 'module' object has no attribute 'rb_source_group_get_by_name'

At least that's something to google for...

mcanard commented 13 years ago

I still have not been able to get this plugin to work, but there are a few changes to make to get past the errors I was able to discover in the log. After making these changes, I was able to get the configure box to display, but I still do not have an entry in the left hand tree.

Changes (apologies for not knowing how to format for this site):

+++ ./radio-browser.py  2011-03-08 12:34:33.041336435 -0700
@@ -117,9 +117,9 @@
    except NotImplementedError:
        entry_type = db.entry_register_type("RadioBrowserEntryType")
    entry_type.category = rhythmdb.ENTRY_STREAM
-       group = rb.rb_source_group_get_by_name ("library")
-       self.source = gobject.new (RadioBrowserSource, shell=shell, name=_("Radio browser"), entry_type=entry_type,source_group=group,plugin=self)
-       shell.append_source(self.source, None)
+       group = rb.rb_display_page_group_get_by_id ("library")
+       self.source = gobject.new (RadioBrowserSource, shell=shell, name=_("Radio browser"), entry_type=entry_type,plugin=self)
+       shell.append_display_page(self.source, None)
    shell.register_entry_type_for_source(self.source, entry_type)
    gobject.type_register(RadioBrowserSource)

@@ -128,7 +128,7 @@
    filepath = self.find_file("radio-browser.png")
    if filepath:
        icon = gtk.gdk.pixbuf_new_from_file_at_size(filepath, width, height)
-           self.source.set_property( "icon",  icon)
+           self.source.set_property( "pixbuf",  icon)

    self.actiongroup = gtk.ActionGroup('RadioBrowserActionGroup')
segler-alex commented 13 years ago

hi folks,

thank you for trying to help with this problem, i use ubuntu, and did not run into this problem yet :) because they still have rhythmbox 13.1 the bad thing about rhythmbox is, they do not have a good api documentation. i do not find anything there. most of the time i look arround to find a piece of code that does the thing i want.

last time the abi changed, someone from ubuntu core had the same problem and fixed it for my plugin too. so if you get past this problem. i will gladly put it into upstream. thank you for your effort!!!

TonyParkin commented 13 years ago

I also run Ubuntu.. but now it has automatically upgraded me to Rhythmbox 13.3 I also cannot get this plugin to work.

The Radio Browser item does not show up in the menu column... and when I visit the Plugins list although i can see it listed, and turn it on and off, I cannot get the Configure button to call up a dialog box. :(

edrex commented 13 years ago

waah :) I wanted to try out the radiotime support. eagerly awaiting a fix.

edrex commented 13 years ago

Background regarding API changes:

https://bugs.launchpad.net/rhythmbox-ubuntuone-music-store/+bug/717535 http://osdir.com/ml/general/2010-11/msg06586.html

committed mcandard's patch to a branch with one-liner that gets the source icon back, but main widget is missing still.

https://github.com/segler-alex/rhythmbox-radio-browser/pull/22

edrex commented 13 years ago

This is the commit which makes the plugin API change? http://git.gnome.org/browse/rhythmbox/commit/?h=v0.13.x&id=6a781bc3525749bd6c07f50d258c4ce3bb82f9a1

And this updates the core python plugins: http://git.gnome.org/browse/rhythmbox/commit/?h=v0.13.x&id=e6a5d832947dedaaedf8f04bba62c0140a6b7d25