search

segment-boneyard / analytics-magento

[DEPRECATED] The hassle-free way to integrate analytics into any Magento store.
15 stars 19 forks source link

Refactorings to match specs. Unit and functional tests #10

Closed yaro-atwix closed 10 years ago

ianstormtaylor commented 10 years ago

Nice, these look cool! One more thing is that where are you running these Magento installations? I'd like to have one included and easily runnable in this repository, so that anyone can just it when they clone the repository. Is that possible?

ianstormtaylor commented 10 years ago

Also, can you add a Readme.md to the root of the directory with instructions for how to run the tests (including where to download the required testing tools from), that way new users can just read it to get started. Thanks!

ianstormtaylor commented 10 years ago

Once those fixes are there, I will be able to use the Readme and the bundled installation as if I was the first time user to test it all out.

yaro-atwix commented 10 years ago

Regarding the Magento installations in the repository: sure, we can put them to. Unfortunately, Magento distributive cannot be 'easily runnable' because you need to install it on a server/local computer and then modify some settings which depend on a computer configuration. Actually, I don't think that it makes sense to put Magento distributives into the extension's repository (it's like putting Windows/OSX distributive alongside with an application). It's easy to get almost any version of Magento CE from Github - https://github.com/OpenMage/magento-mirror. What do you think? As for Readme.md - sure, we will make it.

yaro-atwix commented 10 years ago

Also, could you merge this pull request, please. It will be more handy to compare the changes of the next pull request if this one will be merged. Thanks

ianstormtaylor commented 10 years ago

Sounds good. In that case, for the installation, can you add full, detailed instructions to the Readme about how to install a fresh copy of Magento for testing, so that anyone can get started. I'll use that myself too.

slkra commented 10 years ago

Hey Ian,

Actually there is an official manual on that http://www.magentocommerce.com/knowledge-base/entry/ce18-and-ee113-install-upgrade I guess it would be better to just include the link.

Normally Magento stores are not installed by customers, but a full implementations are done by agencies like ours, as Magento is more like a kit of tools rather than a ready solution.

On Tue, Jun 10, 2014 at 8:01 PM, Ian Storm Taylor notifications@github.com wrote:

Sounds good. In that case, for the installation, can you add full, detailed instructions to the Readme about how to install a fresh copy of Magento for testing, so that anyone can get started. I'll use that myself too.

— Reply to this email directly or view it on GitHub https://github.com/segmentio/analytics-magento/pull/10#issuecomment-45641859 .

Viacheslav Kravchuk CEO /// Atwix http://www.atwix.com/ www.atwix.com

Follow us: Facebook http://www.facebook.com/atwixcom | Twitter http://twitter.com/atwixcom | Blog http://www.atwix.com/blog/