search

segment-boneyard / analytics-magento

[DEPRECATED] The hassle-free way to integrate analytics into any Magento store.
15 stars 19 forks source link

Write Key #11

Closed ianstormtaylor closed 10 years ago

ianstormtaylor commented 10 years ago

Hey Alan, gonna just open issues here so we can discuss instead of having a convoluted email thread. Hope that's okay.

First one is that we actually have two different types of keys in Segment, the Write Key and the Read Key (reading is going to be for exporting data), so we should change all the instances of Key here to Write Key I think for clarity.

Examples:

astorm commented 10 years ago

Changed method name to getWriteKey, changed copy to use "Write Key"