Closed ianstormtaylor closed 10 years ago
Also, can we make it under the MIT license?
Here's a copy of ours:
The MIT License (MIT)
Copyright © 2014 Segment.io
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
And then let's also remove the licenses from inside the code files themselves, and instead just keep a single License.md
in the root of the repository.
Ok, we need to make a small refactoring for this purpose. We will let you know when it's finished.
Awesome, yeah feel free to just pull request whenever you get the new setup. And I'll be sure to pull request any changes I make too, just so that we both know what's going on
We've recently created a pull request with bugfixes and refactoring regarding the opened issues. Please, check this out.
Awesome, just merged.
Question: is it necessary to have the segmentio_segmentio
namespace, or can it just be segmentio
? Thanks!
Actually, it's our coding standard and it's necessary in general to avoid namespaces conflict. For example, two different extensions can have the same name: 'checkout'. If there's no vendor name in the extension's title - we have a conflict. But when you use complete titles with a vendor name, you avoid situations like this. Example: 'apple_checkout', 'google_checkout'.
ah gotcha! that makes a lot of sense. i think the namespace we'll want to go with then is segment_analytics
We need to refactor files names and some pieces of code. Working on this
Ian, this is going to take some time as we need to rename files and pieces of code. We need to increase the initial estimate a little bit.
I've just created a new pull request with updated namespace
sweet, thanks!
Can we change the author everywhere to be
Segment.io
since we're going to open-source it under our name? If so, I can write up a description and everything for us to use, just because I'm not sure where all the places I need to update in the code are.