search

segment-boneyard / analytics-magento

[DEPRECATED] The hassle-free way to integrate analytics into any Magento store.
15 stars 19 forks source link

Change exposed model to output HTML instead of using the PHP library #30

Closed ianstormtaylor closed 10 years ago

ianstormtaylor commented 10 years ago

From #23:

I think you're exposing a Magento model that wraps our PHP library? I just realized we shouldn't actually be exposing a proper PHP API, we should expose it in a way that just adds the calls they make there to the page, like we do with WordPress: https://github.com/segmentio/analytics-wordpress/blob/master/analytics-wordpress.php#L150

This is so that all of their tracking goes client-side, which will ease support a ton, and will make for generally keep tabs on the Magento extension a lot easier.

astorm commented 10 years ago

Not sure I follow this one — all our tracking code is client side. The earlier project builds have an integration for the server side module, but after our discussions we're not using it?

Let me know if I'm missing something here.

ianstormtaylor commented 10 years ago

Ah gotcha, should we remove that code then?

astorm commented 10 years ago

Figured it'd be a nice to have if developers wanted to use the backend API — but it'll be easy enough to add back in if we want to. Removed.