spec for traits and properties

[ianstormtaylor]

For the traits dictionaries that are sent we have a spec for them to be named with specific keys, so that we can recognize them in our code and send them to the right providers. For example we recognize firstName instead of customerFirstname. So we'll want to change all of those.

Here's the documentation for the traits. And then for Ecommerce tracking (viewed product, completed order, etc.) we have an additional spec for the special properties that go along with that here: https://segment.io/docs/tracking-api/ecommerce/

So we'll need to fix both of those. Here are some examples of where I see places that need to be fixed:

• https://github.com/segmentio/analytics-magento/blob/master/app/code/community/Atwix/Segmentio/Block/Init.php#L34-L37
• https://github.com/segmentio/analytics-magento/blob/master/app/code/community/Atwix/Segmentio/Block/Track.php#L31-L34
• https://github.com/segmentio/analytics-magento/blob/master/app/code/community/Atwix/Segmentio/Block/Onepage/Success.php#L65

I've also invited you guys to our private spec repository so you can see the entire spec there too.

[ianstormtaylor]

@yaro-atwix how's this one coming?

[yaro-atwix]

Working on this. However, we found the problem with traits and we are going to fix it. But ecommerce part corresponds the specs at the moment.

[yaro-atwix]

We have done with that. Going to include into a next pull requests alongside with the tests

[yaro-atwix]

The pull request with the latest changes has been created