segment-boneyard / analytics-wordpress

[DEPRECATED] The hassle-free way to integrate analytics into any WordPress site.
https://segment.com/docs/platforms/wordpress/
GNU General Public License v2.0
41 stars 34 forks source link

Problem with "Non Interaction" on "Viewed x Page" #70

Closed causehacker closed 7 years ago

causehacker commented 8 years ago

It's hard to tell if this was an oversight in the key name from the first refactor of this plugin, or at some point it was changed and this is a regression bug, however, the code is not operating as expected.

69 implements a change to the key name in the two spots where noninteraction seemingly should be nonInteraction.

Examples on two sites: --before (as is) the following collector triggers ni:0 img

-- after (with this change) the following collector triggers ni:1 img

both are on the same event for "Viewed x Page"

causehacker commented 8 years ago

ping, anyone home? I have to imagine a lot of people have pretty screwed up GA Bounce rates happening.

causehacker commented 7 years ago

Accepted in Pull #69