search

segment-boneyard / analytics.js-integrations

All of the third-party analytics.js integrations.
71 stars 0 forks source link

Initial Elevio integration added #624

Closed duellsy closed 9 years ago

duellsy commented 9 years ago

Allows users to install elevio through Segment.

Uses the identify method to pass user information through to elevio to display relevant help information to the user.

Just let me know if there's anything else required.

sperand-io commented 9 years ago

two comments inline — awesome first pass! thanks!

duellsy commented 9 years ago

Awesome, I'll close this pull, make the requested updates and submit a new pull request. Thanks for the feedback :+1:

f2prateek commented 9 years ago

@duellsy feel free to push the changes in this commit directly, makes code reviews easier rather than going back and forth across multiple PRs :)

duellsy commented 9 years ago

@f2prateek & @sperand-io updates made, and PR re-opened. Thanks for the feedback!

duellsy commented 9 years ago

Not sure what the error is for in the test on circleci, when I run the tests locally it app passes with flying colours: Error loading resource https://static.elev.io/js/v3.js (6). Details: SSL handshake failed

duellsy commented 9 years ago

Looking for some ideas on why there's the SSL issues when tests are run on CircleCI but not locally, any ideas @sperand-io / @f2prateek ?

f2prateek commented 9 years ago

@duellsy Thanks! We're looking into the SSL errors.

duellsy commented 9 years ago

thanks, looking forward to getting this resolved, got me stumped!

yields commented 9 years ago

@duellsy fixed that ssl issue, seems like the tests are now failing because of another issue, can you please rebase? maybe those issues are resolved on master now

duellsy commented 9 years ago

@yields on it, I'll work with it and report back. Thanks.

duellsy commented 9 years ago

@yields our tests look to work fine, but there's 1 error when running all tests, which is test 1 under #initialize for the Google Analytics integration.

I'm assuming this is unrelated to us?

ndhoule commented 9 years ago

@duellsy Yeah, those GA issues are unrelated to you. This is good to go and landed over in https://github.com/segmentio/analytics.js-integrations/pull/638. Thanks for the PR!