search

segment-boneyard / analytics.js-integrations

All of the third-party analytics.js integrations.
71 stars 0 forks source link

Curebit — allow for script url override #647

Closed sperand-io closed 9 years ago

sperand-io commented 9 years ago

Not yet ready to merge. Pending a better understanding of why this is necessary and any potential changes, we'll need to add a customUrl option field to metadata at release time to accommodate the fix.

sperand-io commented 9 years ago

Talkable (née Curebit) routinely makes custom modifications to scripts for clients, and when they do, they give them a different URL from which to load the script. These changes do not affect the implementation logic or public API; they're only modifications to the custom referral landing pages for the customer. So it's important we support this. Full background: https://segment.zendesk.com/agent/tickets/29552

ndhoule commented 9 years ago

Moved to https://github.com/segment-integrations/analytics.js-integration-curebit/issues/1