segment-boneyard / integration-amplitude

Amplitude server-side integration
segment.com
MIT License
4 stars 7 forks source link

default to library if platform invalid #15

Closed djih closed 8 years ago

djih commented 8 years ago

We recently had a few customers report that analytics-php and Analytics.NET platform values are now showing up as null/none. Amplitude officially only supports iOS, Android, and Web, but I think it's valuable to default back to the Segment library if it's not one of those 3. We would rather the platform show analytics-php and Analytics.NET instead of no value at all.

PTAL @hankim813

hankim813 commented 8 years ago

LGTM!

hankim813 commented 8 years ago

@djih deployed :)

djih commented 8 years ago

@hankim813 sweet thanks for the quick response

hankim813 commented 8 years ago

haha np thanks for the PR!