segment-boneyard / integration-amplitude

Amplitude server-side integration
segment.com
MIT License
4 stars 7 forks source link

Only send revenue properties when event has revenue #20

Closed djih closed 8 years ago

djih commented 8 years ago

https://github.com/segment-integrations/integration-amplitude/pull/19 introduced some unexpected behavior for a few of our customers. I added parsing of quantity and price to send on the event, and they get treated as revenue. However, there are many cases where customers will track quantity and price for an event, but not expect it to be treated as revenue, for example looking at a specific item in their online store. This was causing inflated revenue for many of our customers.

The proper way is just to parse out price and quantity if revenue is on the event. Please release this ASAP @f2prateek @hankim813 thanks!

f2prateek commented 8 years ago

LGTM, thanks!