search

segment-boneyard / nightmare

A high-level browser automation library.
https://open.segment.com
19.54k stars 1.08k forks source link

Electron 8 #1598

Open codebling opened 4 years ago

codebling commented 4 years ago

This is a work in progress. Opening PR for more visibility.

Current state

Currently 10 tests are still failing. They are:

From navigation:

1) should succeed properly if request handler is present 2) should support javascript URLs that load pages 3) should fail immediately/not time out for 304 statuses

From navigation/timeouts:

4) should allow actions on a hanging page 5) should allow loading a new page after timing out

From referer:

6) should return referer from headers

From options:

7) should set a single header 8) should set all headers 9) should set headers for that request 10) should allow webPreferences settings

Looking for help

To help updating to Electron 8, submit PRs against the branch here. If there are issues, open them against that repo, as well.

plan

First step is to fix these tests. This is kind of a first "naive" pass at migrating. Since test coverage is quite good for this project, this might actually be all that is needed, but I'd still want to go over the list of breaking changes one by one to make sure each change has been accounted for.

codebling commented 4 years ago

See also discussion in #1539

mjgp2 commented 4 years ago

@codebling - I was trying to look at your failing tests, but some of them I can't really get to the bottom of (e.g. javascript urls not working)

Did you make any more progress?

codebling commented 4 years ago

@mjgp2 Thanks for looking! I didn't work on it any more! I feel like it's 70% there. I don't need it on the project I'm working on right now, so I probably won't look at this again until I do. I'll leave this parked here and hopefully someone can pick up where I left off.