search

segment-integrations / analytics-android-integration-amplitude

The Amplitude analytics-android integration.
https://segment.com/docs/connections/destinations/catalog/amplitude/
2 stars 6 forks source link

Fall back to total if revenue isn't present #20

Closed brennan closed 6 years ago

brennan commented 6 years ago

Addresses issue raised in: https://segment.atlassian.net/browse/PLATFORM-1236

SegmentBot commented 6 years ago

By analyzing the blame information on this pull request, we identified and undefined to be a potential reviewer.

ladanazita commented 6 years ago

I don't think this solves what Gap is seeing - I'm getting some clarification from Emilio now on this, but Gap is expecting that even if revenue is not sent on Order Completed events, we should calculate the revenue with just price and quantity.

He stated that the

Expected Behavior: Revenue appears in Amplitude on Order Completed Events even if only "price" and "quantity" are sent

I would disagree and say that Order Completed events should have the field revenue included as per our spec.

Also, I would break the circle fixes into a separate PR

f2prateek commented 6 years ago

I see this was mentioned, but for the future, the Circle CI fixes should have been a refactor into a seperate PR.

brennan commented 6 years ago

Will do - thanks!