Add two user settings; update tests to reflect addition

segment-integrations / analytics-android-integration-amplitude

The Amplitude analytics-android integration.

https://segment.com/docs/connections/destinations/catalog/amplitude/

2 stars 6 forks source link

Add two user settings; update tests to reflect addition #26

Closed brennan closed 7 years ago

brennan commented 7 years ago

Satisfies JIRA issue: https://segment.atlassian.net/browse/PLATFORM-1634

SegmentBot commented 7 years ago

By analyzing the blame information on this pull request, we identified and undefined to be a potential reviewer.

ladanazita commented 7 years ago

Before Prateek says it - two separate PRs?

I think location functionality could be group with enable and disable (if Android has this). Did we decide if we should also include a setting to force poll location?

Then useAdvertisingIdForDeviceId in it's own

f2prateek commented 7 years ago

Yes, this should be seperate PRs (and should have been two separate JIRA tickets or at least subtasks within the top level JIRA ticket).