Update traitsToIncrement and traitsToSetOnce tests

segment-integrations / analytics-android-integration-amplitude

The Amplitude analytics-android integration.

https://segment.com/docs/connections/destinations/catalog/amplitude/

2 stars 6 forks source link

Update traitsToIncrement and traitsToSetOnce tests #40

Closed brennan closed 7 years ago

brennan commented 7 years ago

Injects Identify mock into AmplitudeIntegration class
Updates traitsToIncrement and traitsToSetOnce to test all specced data types for these methods: integer, double, float long, String

SegmentBot commented 7 years ago

By analyzing the blame information on this pull request, we identified and undefined to be a potential reviewer.

f2prateek commented 7 years ago

Alternatively, you don't need this new abstraction. The test pattern you had before this PR was fine as well; all that needs to be changed there is to make sure you're testing with all the cases for all the types.