Update README.md - Githubissues

segment-integrations / analytics-ios-integration-adobe-analytics

Segment's Adobe Analytics Integration for Analytics-iOS

MIT License

1 stars 2 forks source link

Update README.md #34

Open XavierAgostini opened 5 years ago

XavierAgostini commented 5 years ago

update installation instructions to explicitly use pod version
not having the version causes the app build to fail

srthurman commented 5 years ago

cc @CarlosMecha for final approval before merging in.

ladanazita commented 5 years ago

@XavierAgostini Why have customers pin a beta version here?

We should also have tests passing prior to merging.

Also, for documentation purposes, this is one of many places these instructions exist. Be sure to update:

Partner portal instructions under components -> iOS
Segment public documentation
To update Cocoapods with instructions, we will have to wait until the next release occurs.

XavierAgostini commented 5 years ago

@ladanazita the previous documentation had the incorrect dependency names. Also for some reason, the apps were all able to compile in our test apps and a customers app only when the dependency version was specified.

ladanazita commented 5 years ago

Ah yes, I think this integration has been in beta due to the lack of a beta release process. The latest is 1.1.1-beta — should we update to point to that?

Have you debugged the failing tests?

XavierAgostini commented 5 years ago

@ladanazita we tested this again today, and we were only able to get the integration to load by specifying the version and the beta flag. CI is saying the issue is:

Warning: Permanently added 'github.com,192.30.253.113' (RSA) to the list of known hosts.

Permission denied (publickey).

fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

git command i returned 128:

briemcnally commented 4 years ago

@XavierAgostini is this still an issue we want to update?