Closed ladanazita closed 6 years ago
@f2prateek and @brennan implemented requested changes.
For Brennan's comment, as discussed I decided not to consider other potential ecommerce events mapped in eventsV2. We can revisit this later when we scope out order wide currency events.
Note that if an ecommerce event is triggered that is not one of the reserved ecommerce events in Adobe, the logic will never send &&products
since we are only continuing into the mapProducts logic if event.name == Product Added
, Product Removed
, Cart Viewed
, Checkout Started
or Order Completed
.
If the event name does match up, we will send over the Adobe event name as both the event name argument through trackAction
and as the value for &&events
.
ping @f2prateek @brennan
@f2prateek As requested, I moved the logic which built the products String outside of formatProducts
. formatProducts
no longer takes in the product string.
Also added a giant comment showing the expected input of formatProduct
and output.