search

segment-integrations / analytics-ios-integration-amplitude

The Amplitude analytics-ios integration.
MIT License
11 stars 45 forks source link

only send revenue event if event has revenue #16

Closed djih closed 8 years ago

djih commented 8 years ago

Similar to https://github.com/segment-integrations/integration-amplitude/pull/20, we need to fix a bug introduced with this merge: https://github.com/segment-integrations/analytics-ios-integration-amplitude/pull/13.

Basically there are cases when customers want to track price as a property, without intending to track it as revenue. We should only explicitly pull the price when the event has revenue.

Also accidentally committed Segment-Amplitude.podspec~ with my previous PR, so deleting it now.

@f2prateek if you could release this ASAP that would be greatly appreciated. Thanks!

SegmentBot commented 8 years ago

By analyzing the blame information on this pull request, we identified @f2prateek, @djih and @tonyxiao to be potential reviewers.