search

segment-integrations / analytics-ios-integration-amplitude

The Amplitude analytics-ios integration.
MIT License
11 stars 45 forks source link

relaxes Analytics dependency #17

Closed ladanazita closed 8 years ago

ladanazita commented 8 years ago

Resolves conflict:

mention-bot commented 8 years ago

@ladanazita, thanks for your PR! By analyzing the history of the files in this pull request, we identified @f2prateek, @tonyxiao and @djih to be potential reviewers.

SegmentBot commented 8 years ago

By analyzing the blame information on this pull request, we identified @f2prateek, @tonyxiao and @djih to be potential reviewers.

f2prateek commented 8 years ago

Hmmm, I don't think this is quite right. Something else is going on in your sample (can you share the profile and podfile.lock)?

This pod should use anything over 3.2, so it's weird that it's forcing 3.2.0

tonyxiao commented 8 years ago

Ooops, thanks for pointing that out. @ladanazita can you add a bit more info?

f2prateek commented 8 years ago

Ah the issue is in the error message.

The user is using 1.3.0 of this integration. The requirement was relaxed in 1.4.0 https://github.com/segment-integrations/analytics-ios-integration-amplitude/commit/a3299acf152bf68ed1e7c426359414f881f289be