Closed aarons22 closed 3 years ago
@evelynccordner What is the status of this fix? This would really improve our CI. Will buy cake and celebrate the day this fix is merged! Thanks!
@noentiger from what I can tell, there is no guarantee this gets merged, but you can always fork or use this branch directly:
pod 'Segment-Firebase', :git => 'git@github.com:aarons22/analytics-ios-integration-firebase.git', :branch => 'custom-settings'
Which is what I'm doing right now :)
@aarons22 That's true! Thanks :)
@briemcnally @ladanazita Any chance this will be merged/released?
Hi all - I'm Sara, the Engineering Product Manager for Destinations. Currently, we don’t have a timeline on when we might be able to merge in this change. We appreciate your patience and your contributions here :)
Hi Sara, I assume it means never ;)
Hi @Armenm - I wouldn't say never... though I know having "no timeline" can feel the same when it comes to planning around the update.
arf, when can this be merged?!
Hi @m-vdb - I still don't have a date to share on our side.
Any news on this ? @aarons22 can this PR be updated to resolve merge conflict ?
@rico237 I attempted to fix via GitHub since I'm not longer using this integration. I have not validated the changes locally.
Seems like this can be accomplished by configuring FIRApp before the analytics instance is created. The check for defaultApp is already present to bypass calling configure. Closing, but please reopen if I'm not understanding some aspect.
This fixes #21