search

segment-integrations / analytics-ios-integration-firebase

Segment's bundled integration for Firebase on iOS
MIT License
13 stars 92 forks source link

Bugfix: do not configure FIRApp if already done #42

Closed m-vdb closed 3 years ago

m-vdb commented 5 years ago

Fixes #36 Closes #37

Followed recommendations of @vargero on #37

vargero commented 5 years ago

This has been used by my app for some months now, it prevents a stupid crash on Firebase when trying to configure it twice, by checking wether we need to configure it again or not.

vargero commented 5 years ago

Thanks @m-vdb !

m-vdb commented 5 years ago

@vargero who should we ask for a review + merge?

vargero commented 5 years ago

I honestly don't know, possibly @wcjohnson11 or @ladanazita?

agonbina commented 5 years ago

Is there any update to merging and releasing this? It is blocking us from releasing our app with the segment-firebase integration.

vargero commented 5 years ago

@agonbina

You can always fork the code to your repository and point to it on your Podfile. The guys who take care of this repo don’t seem to be responding to this merge request so I’d do as I said (which I had to do on my end as well).

bsneed commented 3 years ago

It appears this work has been done already. Closing.