Don't call [FIRApp configure] on behalf of user's application

segment-integrations / analytics-ios-integration-firebase

Segment's bundled integration for Firebase on iOS

MIT License

13 stars 95 forks source link

Don't call [FIRApp configure] on behalf of user's application #71

Closed shamilovtim closed 3 years ago

shamilovtim commented 3 years ago

This integration is not responsible for instantiating Firebase and to do so usurps authority from user's applications. Please remove calls that configure Firebase on behalf of users and allow users to configure Firebase themselves.

The code that does this can be found here: https://github.com/segment-integrations/analytics-ios-integration-firebase/blob/f1da18d80bed7474b68eacd215adc635f10e31da/Segment-Firebase/Classes/SEGFirebaseIntegration.m#L33

shamilovtim commented 3 years ago

Can you please respond @bsneed

bsneed commented 3 years ago

I understand where you're coming from, but we can't change this unfortunately. It has worked this way literally forever and to stop doing calling [FIRApp configure] now would break every other customer.