segment-integrations / analytics.js-integration-appboy

The Appboy analytics.js integration
https://segment.com/docs/integrations/appboy/
MIT License
0 stars 6 forks source link

Remove Reserved keys EPD-2954 #10

Closed hankim813 closed 7 years ago

hankim813 commented 7 years ago

This resolves https://segment.atlassian.net/browse/EPD-2954

https://www.appboy.com/documentation/Platform_Wide/#reserved-keys

Gotta remove these reserved keys from user attributes or custom event props otherwise Appboy rejects the messages.

todo:

cc @anoonan

codecov-io commented 7 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         102     99    -3     
=====================================
- Hits          102     99    -3
Impacted Files Coverage Δ
lib/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d05c52f...2040eb7. Read the comment docs.