search

segment-integrations / analytics.js-integration-google-analytics

The Google Analytics analytics.js integration.
https://segment.com/docs/integrations/google-analytics/
MIT License
20 stars 23 forks source link

Spec: V2 Ecommerce Events - Missing Product Product List Viewed and Product List Filtered #34

Closed nickrathwell closed 7 years ago

nickrathwell commented 8 years ago

Cannot find any ecommerce tracking in index.js that as code for https://segment.com/docs/spec/ecommerce/v2/#product-list-viewed or https://segment.com/docs/spec/ecommerce/v2/#product-list-filtered

These would need to map to https://developers.google.com/analytics/devguides/collection/analyticsjs/enhanced-ecommerce#product-impression

Was this left out on purpose if yes why?

Thanks Nick

nickrathwell commented 8 years ago

@SegmentBot a reply on this would be appreciated. Thanks, Nick

sperand-io commented 8 years ago

Hey Nick — ditto #35: this was not left out on purpose, but was added to the spec without adding support in the integration. Will leave this open until we get a chance to get the integration up to spec.

Peripheral1994 commented 7 years ago

Closed by https://github.com/segment-integrations/analytics.js-integration-google-analytics/pull/46