search

segment-integrations / analytics.js-integration-google-analytics

The Google Analytics analytics.js integration.
https://segment.com/docs/integrations/google-analytics/
MIT License
20 stars 23 forks source link

allow 0 as metric value #44

Closed maxstoller closed 7 years ago

maxstoller commented 7 years ago

It'd be great if 0 were an acceptable value for custom metrics. We have a custom metric that we're setting to 0 in some track calls, and it's being dropped by Segment before sent to GA.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0ebebac). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage          ?   99.67%           
=========================================
  Files             ?        1           
  Lines             ?      309           
  Branches          ?        0           
=========================================
  Hits              ?      308           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
lib/index.js 99.67% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ebebac...86f6493. Read the comment docs.

Peripheral1994 commented 7 years ago

This fix is queued to be in the next patch very soon - thanks for the PR! :)

maxstoller commented 7 years ago

Thanks!