search

segment-integrations / analytics.js-integration-intercom

The Intercom analytics.js integration.
https://segment.com/docs/integrations/intercom/
MIT License
7 stars 12 forks source link

intercom: post-fix date traits with `_at` #2

Closed ndhoule closed 8 years ago

ndhoule commented 9 years ago

From @ianstormtaylor on June 11, 2014 23:13

Server-side we do this so that Intercom users can see nicely formatted dates, since Intercom doesn't recognize them automatically from the JSON sent. So we should change the client-side integration to do this as well.

We'll need to make it backwards compatible with the old traits as well.

@calvinfo

Copied from original issue: segmentio/analytics.js-integrations#209

ndhoule commented 9 years ago

Here's where we do it in the server-side integration: https://github.com/segmentio/integration-intercom/blob/61a47642a7e5fafeffdbd05597052c8ac51564a9/lib/index.js#L115

hankim813 commented 8 years ago

this has been implemented https://github.com/segment-integrations/analytics.js-integration-intercom/blob/master/lib/index.js#L99-L104