Closed anoonan closed 7 years ago
Merging #20 into master will increase coverage by
0.44%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
+ Coverage 98.76% 99.2% +0.44%
=========================================
Files 1 1
Lines 81 126 +45
=========================================
+ Hits 80 125 +45
Misses 1 1
Impacted Files | Coverage Δ | |
---|---|---|
lib/index.js | 99.2% <100%> (+0.44%) |
:white_check_mark: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5a7c66a...2b49b18. Read the comment docs.
LGTM after recent changes!
This PR will allow you to map your traits/properties in your Segment <> Intercom UI settings whereby you can tell us which property/trait you'd like us to stringify, flatten, or drop. You can also now set a default method to handle nested objects.
logic:
did you blacklist a trait?
-If yes, how would you like the trait to be handled: dropped, flattened, or stringified -If no, the default method that the customer has selected will handle the nested trait. (the default method will be set to 'flatten' because that is how we are currently handling nested objects on the server side.)
server side PR: https://github.com/segment-integrations/integration-intercom/pull/41
TODO: