segment-integrations / analytics.js-integration-intercom

The Intercom analytics.js integration.
https://segment.com/docs/integrations/intercom/
MIT License
7 stars 12 forks source link

add option to handle nested objects EPD-1473 #20

Closed anoonan closed 7 years ago

anoonan commented 7 years ago

This PR will allow you to map your traits/properties in your Segment <> Intercom UI settings whereby you can tell us which property/trait you'd like us to stringify, flatten, or drop. You can also now set a default method to handle nested objects.

logic:

server side PR: https://github.com/segment-integrations/integration-intercom/pull/41

TODO:

codecov-io commented 7 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.44%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #20      +/-   ##
=========================================
+ Coverage   98.76%   99.2%   +0.44%     
=========================================
  Files           1       1              
  Lines          81     126      +45     
=========================================
+ Hits           80     125      +45     
  Misses          1       1
Impacted Files Coverage Δ
lib/index.js 99.2% <100%> (+0.44%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a7c66a...2b49b18. Read the comment docs.

hankim813 commented 7 years ago

LGTM after recent changes!