search

segment-integrations / analytics.js-integration-intercom

The Intercom analytics.js integration.
https://segment.com/docs/integrations/intercom/
MIT License
7 stars 12 forks source link

migrate intercom inbox activator #3

Closed ndhoule closed 8 years ago

ndhoule commented 9 years ago

From @reinpk on May 7, 2014 21:34

from our side we have two different settings:

Then Intercom added a UI checkbox to control whether the inbox shows. But! If an activator is passed, they’ll show it regardless of what their UI checkbox is set to.

So from the “right” way to do things, realistically their UI should just be the final decision on whether to show the inbox or not. But I guess they may have backwards compatibility issues with that, which is why they don’t do it?

From our side, we had been defaulting people to have the default activator of #IntercomDefaultWidget but that means that even if people turn off the inbox setting in Intercom, it will still be on cuz we’re sending an activator. So, if we want to fix it it will require a migration:

  1. Set the new default for the activator to empty string.
  2. Everyone with Intercom inbox off, and activator is #IntercomDefaultWidget replace the activator with empty string.
  3. Remove the Intercom inbox setting.

What we want to end up with in the end is that we don’t control the default inbox being on at all, we just let people use a custom activator if they want (which will turn the inbox on).

cc @yields @ianstormtaylor

Copied from original issue: segmentio/analytics.js-integrations#138

ndhoule commented 9 years ago

Seems like there's a related PR for this in https://github.com/segmentio/migrations/pull/1?

hankim813 commented 8 years ago

What we want to end up with in the end is that we don’t control the default inbox being on at all, we just let people use a custom activator if they want (which will turn the inbox on).

This has been implemented! :)